Authorization header issue before initialize SwaggerUI
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#73](https://github.com/ruby-grape/grape-swagger-rails/pull/73): Authorization header issue before initialize `SwaggerUI` - [@mur-wtag](https://github.com/mur-wtag).Generated by 🚫 danger |
|
Do you think you can write a test that actually reproduces this? |
added 5 commits
October 3, 2016 17:04
CORE-826
CORE-826
CORE-826
|
@mur-wtag I think the idea was to create a capybara/selenium spec that with will fail unless your fix is available. See https://github.com/ruby-grape/grape-swagger-rails/blob/master/spec/features/swagger_spec.rb to find spec samples |
|
+1 @serggl, right now these specs pass, so make a spec that fails, apply a fix and see it succeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-826
Bug Description:
Consider this code block:
This code block going to initialize
SwaggerUi.But To initialize
SwaggerUiwe need to have authorization header. And the insideonCompletewe are addingAuthorization Headerby callingaddApiKeyAuthorization().So, initialization of
SwaggerUifails and triggersonFaiulre:pAnd this resolution is to add header before initialize
SwaggerUISome discussions: